bruno-roustant commented on code in PR #3412:
URL: https://github.com/apache/solr/pull/3412#discussion_r2175399936
##########
solr/core/src/java/org/apache/solr/update/DirectUpdateHandler2.java:
##########
@@ -336,11 +336,18 @@ public int addDoc(AddUpdateCommand cmd) throws
IOException {
+ errorDetails;
throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, errorMsg,
iae);
} catch (RuntimeException t) {
+ SolrException.ErrorCode errorCode =
Review Comment:
Previously the error code was always set to 4xx, whereas it is asserted to
5xx in RequestHandlerBase.wrapLuceneTragicExceptionIfNecessary(). So I propose
to check here the "tragedy" state and set the error code correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
