bruno-roustant commented on code in PR #3412:
URL: https://github.com/apache/solr/pull/3412#discussion_r2175404275


##########
solr/core/src/java/org/apache/solr/update/TransactionLog.java:
##########
@@ -247,6 +248,9 @@ protected TransactionLog(
         } catch (Exception e) {
           log.error("Error closing tlog file (after error opening)", e);
         }
+        if (!openExisting) {

Review Comment:
   Main point of this fix: delete the transaction log file in case of 
exception. Otherwise the "id" field in UpdateLog will always point to this file 
and next TransactionLog constructor calls will always throw the "New 
transaction log already exists" exception, blocking all updates.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to