renatoh commented on code in PR #3426:
URL: https://github.com/apache/solr/pull/3426#discussion_r2200633076
##########
solr/modules/llm/src/test/org/apache/solr/llm/textvectorisation/update/processor/TextToVectorUpdateProcessorTest.java:
##########
@@ -40,6 +41,13 @@ public static void cleanup() throws Exception {
afterTest();
}
+ @After
Review Comment:
yes, now with the @After, even if I make one test fail on purpose, the
result is consistent across 5 test runs. Without the @After one failing test
has unwanted side effect and other test of the class are randomly failing due
to the data which got not cleaned up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
