alessandrobenedetti commented on code in PR #3426:
URL: https://github.com/apache/solr/pull/3426#discussion_r2200678579
##########
solr/modules/llm/src/test/org/apache/solr/llm/textvectorisation/update/processor/TextToVectorUpdateProcessorFactoryTest.java:
##########
@@ -132,7 +132,7 @@ public void
init_notDenseVectorOutputField_shouldThrowExceptionWithDetailedMessa
/* Following test depends on a real solr schema and depends on
BeforeClass-AfterClass methods */
@Test
- public void
init_notExistentInputField_shouldThrowExceptionWithDetailedMessage() {
+ public void init_notExistentInputField_shouldNotThrowException() {
Review Comment:
mmm, so what would happen if the user specifies in the input a non-existent
field? For example, because of a typo?
Will it just silently fail?
If that's the case, we need to differentiate between non-existent and 'non
explicitly defined but compatible with a dynamic field' I suspect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
