renatoh commented on code in PR #3426:
URL: https://github.com/apache/solr/pull/3426#discussion_r2200648992
##########
solr/modules/llm/src/test/org/apache/solr/llm/textvectorisation/update/processor/TextToVectorUpdateProcessorFactoryTest.java:
##########
@@ -132,7 +132,7 @@ public void
init_notDenseVectorOutputField_shouldThrowExceptionWithDetailedMessa
/* Following test depends on a real solr schema and depends on
BeforeClass-AfterClass methods */
@Test
- public void
init_notExistentInputField_shouldThrowExceptionWithDetailedMessage() {
+ public void init_notExistentInputField_shouldNotThrowException() {
Review Comment:
But this test will fail with the changes I did to
TextToVectorUpdateProcessorFactory.java, since the exception is not thrown
anymore. If we want to keep this test we need to distinguish somehow between a
dynamic field and a non-dynamic field within
TextToVectorUpdateProcessorFactory.java, in order to throw the exception only
for dynamic fields, not sure if this would make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
