HoustonPutman opened a new pull request, #3429: URL: https://github.com/apache/solr/pull/3429
https://issues.apache.org/jira/browse/SOLR-17792 https://github.com/apache/solr/pull/3398 accidentally broke the error handling in HttpShardHandler, by accepting already received requests after cancelling. So instead of throwing those responses away, the HttpShardHandler will find a response with an error after cancelling, since that is the contract that `take()` has. And even then, for tolerant requests, the `SearchHandler` needs to find any responses that have errors to know if the results are partial or not. (because tolerant requests don't guarantee that the response returned is the one with the error) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
