HoustonPutman commented on PR #3429: URL: https://github.com/apache/solr/pull/3429#issuecomment-3085733921
> is there a flaky test that this PR is expected to fix? Yes. Both `DistributedDebugComponentTest.testTolerantSearch` and `TestJsonFacets.testTolerant`. > Instance-nesting and code like previousResponse.getShardRequest().responses makes things hard to reason about at a glance (IMO) I completely agree, and that's not really necessary anymore IMO. Except that the API that ShardHandler promises says that the response given back will contain the error. The SearchHandler code doesn't use that anymore, but still it's good to keep the contract until we change the APIs entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
