gerlowskija commented on PR #3429: URL: https://github.com/apache/solr/pull/3429#issuecomment-3085040291
This LGTM - is there a flaky test that this PR is expected to fix? I can try to keep a second set of eyes to make sure it's doing what we expect post-merge. > we should redesign the ShardHandler interface, because this contract really doesn't make much sense Agreed, I think things could be a lot simpler if we went back to the drawing board on the design. It's also really difficult to reason about. Instance-nesting and code like `previousResponse.getShardRequest().responses` makes things hard to reason about at a glance (IMO) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
