dsmiley commented on code in PR #3500:
URL: https://github.com/apache/solr/pull/3500#discussion_r2295029647
##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -861,25 +861,17 @@ public NodeConfigBuilder setHiddenSysProps(String
hiddenSysProps) {
}
/**
- * Finds list of hiddenSysProps requested by system property or
environment variable or the
- * default
+ * Finds list of hiddenSysProps requested in priority of solr.xml, system
property or the
+ * default set
*
- * @return set of raw hidden sysProps, may be regex
+ * @return set of raw hidden system properties, may be regex
*/
private Set<String> resolveHiddenSysPropsFromSysPropOrEnvOrDefault(String
hiddenSysProps) {
Review Comment:
shouldn't this use EnvUtils?
##########
solr/core/src/java/org/apache/solr/handler/configsets/ConfigSetAPIBase.java:
##########
@@ -96,10 +96,10 @@ protected void runConfigSetCommand(
}
protected void ensureConfigSetUploadEnabled() {
- if (!"true".equals(System.getProperty("configset.upload.enabled",
"true"))) {
+ if (!"true".equals(System.getProperty("solr.configset.upload.enabled",
"true"))) {
Review Comment:
shouldn't this use EnvUtils?
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##########
@@ -89,7 +89,7 @@ public abstract class CloudSolrClient extends SolrClient {
// no of times collection state to be reloaded if stale state error is
received
private static final int MAX_STALE_RETRIES =
- Integer.parseInt(System.getProperty("cloudSolrClientMaxStaleRetries",
"5"));
+
Integer.parseInt(System.getProperty("solr.solrj.cloud.max.stale.retries", "5"));
Review Comment:
shouldn't this use EnvUtils?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
