dsmiley commented on code in PR #3500:
URL: https://github.com/apache/solr/pull/3500#discussion_r2296343319
##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -861,25 +861,17 @@ public NodeConfigBuilder setHiddenSysProps(String
hiddenSysProps) {
}
/**
- * Finds list of hiddenSysProps requested by system property or
environment variable or the
- * default
+ * Finds list of hiddenSysProps requested in priority of solr.xml, system
property or the
+ * default set
*
- * @return set of raw hidden sysProps, may be regex
+ * @return set of raw hidden system properties, may be regex
*/
private Set<String> resolveHiddenSysPropsFromSysPropOrEnvOrDefault(String
hiddenSysProps) {
Review Comment:
> Also, maybe using EnvUtils would let me change this method to
resolveHiddenSysPropsFromEnvUtilsOrDefault as a name???
Yes exactly! This is a large part of the very point of EnvUtils! Jan
introduced EnvUtils but didn't convert our codebase to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
