dsmiley commented on code in PR #3500:
URL: https://github.com/apache/solr/pull/3500#discussion_r2296342819
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java:
##########
@@ -89,7 +89,7 @@ public abstract class CloudSolrClient extends SolrClient {
// no of times collection state to be reloaded if stale state error is
received
private static final int MAX_STALE_RETRIES =
- Integer.parseInt(System.getProperty("cloudSolrClientMaxStaleRetries",
"5"));
+
Integer.parseInt(System.getProperty("solr.solrj.cloud.max.stale.retries", "5"));
Review Comment:
Yes; use EnvUtils to read any property that starts with "solr".
Consistency. Your PRs here are the perfect time to do this at the same time as
renames. I don't suggest you necessarily touch additional lines, but at least
update the lines you need to touch for sys prop name changes.
CC @janhoy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
