dsmiley commented on code in PR #4064: URL: https://github.com/apache/solr/pull/4064#discussion_r2722830246
########## solr/solrj/src/java/org/apache/solr/client/solrj/request/CommitOptions.java: ########## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.client.solrj.request; + +/** + * Encapsulates commit and optimize options for update requests. This class provides a type-safe way + * to specify commit parameters instead of using multiple boolean parameters in method signatures. + * + * @since Solr 10.0 + */ +public class CommitOptions { Review Comment: Since this is *so* perfect for a `record`, I have a hard time accepting a "no" merely because you aren't familiar. Eric, you have been so empowered by Claude -- you can just tell it for you. I'd first recommend seeing if IntelliJ will do it for you -- which is even better. I don't think it makes sense to *not* do a record here merely because we only have a few records elsewhere in the codebase right now. Who cares; you are *introducing* this new code. It should exist as it's best/ideal self. If we were debating an existing class in a PR that touches it, then I'd be sympathetic to that argument as being out of scope. If you are still uncomfortable, I'll happily do it myself on this PR; LMK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
