epugh commented on PR #4064: URL: https://github.com/apache/solr/pull/4064#issuecomment-3796893829
> Partially reviewed/commented. Please don't merge this yet. > > I think we're venturing into the territory where I'm very opinionated on **not** continuing to use current names that have been confusing to anybody that isn't a deep Solr expert. I don't want to burden you with addressing my feedback when you had a more narrow scope in mind so I'm willing to put in the effort to see this through, if you want to wipe your hands of this. Yeah.... My goal was to merely remove waitFlush, and it has definitly snowballed beyond that into a rethinking of our semantics. If you think this is something that you want to actively work on and pick up from now, then I'm happy to hand it over and take a supporting role. However, if this isn't in your immediate future to work on, it would be a shame to not get this over the finish line. I think if we were to just try to get this over the finish line, we can fairly quickly remove the javadocs that aren't helping, and then leave the big semantic discussions for a future time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
