gerlowskija commented on PR #4073: URL: https://github.com/apache/solr/pull/4073#issuecomment-3807619480
Apologies again for catching this effort so late after it started. I'm a big fan of some of the benefits discussed above (e.g. getting hardcoding out of SolrCore.java). Moving more into ImplicitPlugins.json is a Good Thing! But I worry about the proposal to allow configsets to specify a replacement ImplicitPlugins.json. We definitely need to allow users to customize this somehow, just not sure this is the best approach. Mainly worried about redundancy and causing confusion for users, as I mentioned above. That said - this PR isn't actually doing any of the configset-override stuff that I'm concerned about. So I'll continue discussion of the overall approach on [the relevant dev@ thread](https://lists.apache.org/thread/82bj2l5b4s5rs9k45q9k2vf3o39t6bpg). (Which I overlooked up until now). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
