gerlowskija commented on code in PR #4073:
URL: https://github.com/apache/solr/pull/4073#discussion_r2733907758
##########
solr/core/src/resources/ImplicitPlugins.json:
##########
@@ -157,5 +157,25 @@
"activetaskslist"
]
}
+ },
Review Comment:
[0] Github won't let me leave an in-line comment on it, as it's not a line
changed by this PR. But this file contains an "/admin/system" request handler
registration that seems like a real outlier as it's a "node-level" or "admin"
API. (The rest of the APIs in this file are core-level)
[We already have code in CoreContainer to register the "info"
handler](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/core/CoreContainer.java#L886),
so maybe the section could just be removed from this file altogether?
(Not sure it's specifically related to this PR. But Eric and I were
discussing the PR on the phone and @epugh asked me to flag the anomaly here
after we noticed it.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
