[
https://issues.apache.org/jira/browse/SOLR-18112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18069998#comment-18069998
]
Chris M. Hostetter commented on SOLR-18112:
-------------------------------------------
{quote}Shouldn't searchNonExistingCollection simply look for status code 404?
{quote}
yeah, that's much cleaner.
{quote}Or even if the catch statement could have something like...
{quote}
Or maybe even cleaner:
* Change {{doWork}} declaration to {{throws Exception}}
** most of the methods {{doWork}} calls should just throw/propagate an
Exception for problems they encounter
** {{searchNonExistingCollection}} can catch {{RemoteSolrException}} and
rethrow if it's not 404 (but let any other type of Exception propagate up)
* Git rid of {{addFailure()}} and just move that logic into a {{try+catch
(Exception)}} block in the {{run()}} method's {{while (!timeout)}} loop body
> Convert SolrDispatchFilter to a Servlet
> ---------------------------------------
>
> Key: SOLR-18112
> URL: https://issues.apache.org/jira/browse/SOLR-18112
> Project: Solr
> Issue Type: Improvement
> Components: Server
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Fix For: 10.1
>
> Attachments:
> SOLR-18112__fix_ConcurrentDeleteAndCreateCollectionTest_due_to_changed_error_msg.patch
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> SolrDispatchFilter ought to be an HttpServlet, not an HttpFilter. It may
> simplify things internally... but really this is a principled change.
> An example of something simpler would be that it'll be easy to ensure that
> the actual filters target only Solr and not any other Servlets that someone
> might want to add.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
