[
https://issues.apache.org/jira/browse/SOLR-18112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070148#comment-18070148
]
Chris M. Hostetter commented on SOLR-18112:
-------------------------------------------
Hmmm, there are a couple of "extra" changes that seem like they were
intentionally, but they also seem to make the test weaker/slower?
* you removed the {{failure.get().addSuppressed(e)}} logic, so if more then one
thread encounters an exception, only the "last" one will be reported in the
test results
* {{createCollection()}} and {{deleteCollection()}} no longer check
{{CollectionAdminResponse.getStatus()}} (and throw an exception if non-zero)
... which i _believe_ means some types of errors will not longer trigger test
failures?
* you removed the {{failure.get() == null}} check from the while conditional --
i think because you put a {{break}} in the catch block -- but that means any
*other* threads will continue to loop until the time out (making the test take
a fixed amount of time) even if one ore more threads have already found a
failure case.
> Convert SolrDispatchFilter to a Servlet
> ---------------------------------------
>
> Key: SOLR-18112
> URL: https://issues.apache.org/jira/browse/SOLR-18112
> Project: Solr
> Issue Type: Improvement
> Components: Server
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Fix For: 10.1
>
> Attachments:
> SOLR-18112__fix_ConcurrentDeleteAndCreateCollectionTest_due_to_changed_error_msg.patch
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> SolrDispatchFilter ought to be an HttpServlet, not an HttpFilter. It may
> simplify things internally... but really this is a principled change.
> An example of something simpler would be that it'll be easy to ensure that
> the actual filters target only Solr and not any other Servlets that someone
> might want to add.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
