[
https://issues.apache.org/jira/browse/SOLR-18112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070152#comment-18070152
]
David Smiley commented on SOLR-18112:
-------------------------------------
I'll add back "addSuppressed" & stopping the loop – good catch. I forgot this
is running in parallel.
RE checking response.getStatus... in my experience there's no point since SolrJ
throws exceptions. Am I wrong?
> Convert SolrDispatchFilter to a Servlet
> ---------------------------------------
>
> Key: SOLR-18112
> URL: https://issues.apache.org/jira/browse/SOLR-18112
> Project: Solr
> Issue Type: Improvement
> Components: Server
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Fix For: 10.1
>
> Attachments:
> SOLR-18112__fix_ConcurrentDeleteAndCreateCollectionTest_due_to_changed_error_msg.patch
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> SolrDispatchFilter ought to be an HttpServlet, not an HttpFilter. It may
> simplify things internally... but really this is a principled change.
> An example of something simpler would be that it'll be easy to ensure that
> the actual filters target only Solr and not any other Servlets that someone
> might want to add.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
