dsmiley opened a new pull request, #4266: URL: https://github.com/apache/solr/pull/4266
https://issues.apache.org/jira/browse/SOLR-18188 This PR switches nearly all tests that were using Apache HttpClient *directly* to instead use Jetty HttpClient (or in some cases a plain SolrClient given we can do a lot with them). Also any tests with `import org.apache.http`. As of this writing, I deferred ~8 tests that casted a cloud client to CloudLegacySolrClient to then call getHttpClient merely to create an HttpSolrClient with the same backing client -- maybe for efficiency. TBD on their fate. SimplePrinciple was made a record and used in places where an Apache variant was used. In URLUtils, I added a new method: buildURI which is needed in RestTestHarness, BackupRestoreUtils, and I think eventually more places. It handles URI encoding matters. Apparently Apache HttpClient was doing things implicitly that Jetty doesn't. _This is another step in a journey that continues_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
