dsmiley commented on code in PR #4266:
URL: https://github.com/apache/solr/pull/4266#discussion_r3041826688
##########
solr/core/src/test/org/apache/solr/cloud/TestPullReplica.java:
##########
@@ -140,23 +136,25 @@ public void testCreateDelete() throws Exception {
break;
case 1:
// Sometimes use v1 API
- String url =
+ var jetty1 = cluster.getRandomJetty(random());
+ String url1 =
String.format(
Locale.ROOT,
"%s/admin/collections?action=CREATE&name=%s&collection.configName=%s&numShards=%s&pullReplicas=%s",
- cluster.getRandomJetty(random()).getBaseUrl(),
+ jetty1.getBaseUrl(),
collectionName,
"conf",
2, // numShards
3); // pullReplicas
// These options should all mean the same
- url = url + pickRandom("", "&nrtReplicas=1", "&replicationFactor=1");
- HttpGet createCollectionGet = new HttpGet(url);
- getHttpClient().execute(createCollectionGet);
+ url1 = url1 + pickRandom("", "&nrtReplicas=1",
"&replicationFactor=1");
Review Comment:
I'm able to address most/all of those issues via simply using
switch-expressions, which creates blocks of isolated scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
