dsmiley commented on code in PR #4266:
URL: https://github.com/apache/solr/pull/4266#discussion_r3041445738
##########
solr/core/src/test/org/apache/solr/core/TestSolrConfigHandler.java:
##########
@@ -976,6 +974,14 @@ public static LinkedHashMapWriter getRespMap(String path,
RestTestHarness restHa
}
}
+ @SuppressWarnings({"rawtypes"})
+ private static LinkedHashMapWriter getRespMap(String baseUrl, String path)
throws Exception {
+ // a hack... if possible pass in an httpClient and also be able to init
RestTestHarness with it
Review Comment:
"hack" is possibly overstated. It's not ideal to create a new harness
(which creates a client) when I'd rather somehow re-use a client. I don't
think I feel strongly enough now to bother with TODO here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
