dsmiley commented on code in PR #4272:
URL: https://github.com/apache/solr/pull/4272#discussion_r3055261987
##########
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java:
##########
@@ -433,6 +429,16 @@ private String buildUrl(String url) {
return url;
}
+ /**
+ * Get url scheme of a standalone server based on system property
"solr.ssl.enabled".
Review Comment:
it's mode-neutral.
##########
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java:
##########
@@ -433,6 +429,16 @@ private String buildUrl(String url) {
return url;
}
+ /**
+ * Get url scheme of a standalone server based on system property
"solr.ssl.enabled".
+ *
+ * @return http or https
+ */
+ private String getUrlScheme() {
Review Comment:
As a method it's suggestive for anyone to potentially call it beyond the
only caller -- `init()`. Notice that init() is only trying to initialize
`this.scheme` and that null is very valid; see `buildUrl()`. So lets just do
that without this method here, leaving it as null if the sys prop isn't set.
##########
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java:
##########
@@ -104,8 +105,8 @@ public class HttpShardHandlerFactory extends
ShardHandlerFactory
private RequestReplicaListTransformerGenerator
requestReplicaListTransformerGenerator =
new RequestReplicaListTransformerGenerator();
- // URL scheme to be used in distributed search.
- static final String INIT_URL_SCHEME = "urlScheme";
Review Comment:
Curious; was `urlScheme` arg documented in the ref guide or present in a
published solr.xml that people use? If so we'll want to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
