VishnuPriyaChandraSekar commented on code in PR #4272:
URL: https://github.com/apache/solr/pull/4272#discussion_r3060194382
##########
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java:
##########
@@ -104,8 +105,8 @@ public class HttpShardHandlerFactory extends
ShardHandlerFactory
private RequestReplicaListTransformerGenerator
requestReplicaListTransformerGenerator =
new RequestReplicaListTransformerGenerator();
- // URL scheme to be used in distributed search.
- static final String INIT_URL_SCHEME = "urlScheme";
Review Comment:
Looks like `urlScheme` is an optional field in solr.xml [1]. In order to
provide backward compatibility, I think the precedence to lookup the urlScheme
should be 1) `solr.ssl.enabled` 2) urlScheme from solr.xml 3) default (null).
[1]
https://solr.apache.org/guide/solr/latest/configuration-guide/configuring-solr-xml.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
