VishnuPriyaChandraSekar commented on code in PR #4272:
URL: https://github.com/apache/solr/pull/4272#discussion_r3126135855
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/ClusterStateProviderTest.java:
##########
@@ -472,29 +472,41 @@ public void testZkClusterStateProviderUrlScheme() throws
Exception {
}
private void testUrlSchemeDefault(SolrZkClient client) throws Exception {
+ if (isSSLMode()) {
+ System.clearProperty(SOLR_SSL_ENABLED);
+ }
try (var zkStateReader = new ZkStateReader(client);
var clusterStateProvider = new
ZkClientClusterStateProvider(zkStateReader)) {
assertEquals("http", clusterStateProvider.getUrlScheme());
+ } finally {
+ if (isSSLMode()) {
+ System.setProperty(SOLR_SSL_ENABLED, "true");
+ }
}
}
private void testUrlSchemeWithSystemProperties(SolrZkClient client) throws
Exception {
- System.setProperty(SOLR_SSL_ENABLED, "true");
Review Comment:
TIL :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
