epugh commented on code in PR #4275:
URL: https://github.com/apache/solr/pull/4275#discussion_r3059242799
##########
solr/core/src/java/org/apache/solr/cli/VersionTool.java:
##########
@@ -31,8 +40,24 @@ public String getName() {
return "version";
}
+ @Override
+ public Options getOptions() {
+ return super.getOptions()
+ .addOption(CommonCLIOptions.SOLR_URL_OPTION)
Review Comment:
Do we need to support the --zk option to connect for consistency? Don't all
our tools allow both??
##########
solr/core/src/test/org/apache/solr/cli/VersionToolTest.java:
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.cli;
+
+import org.apache.solr.cloud.SolrCloudTestCase;
+import org.apache.solr.embedded.JettySolrRunner;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+public class VersionToolTest extends SolrCloudTestCase {
+
+ @BeforeClass
+ public static void setupCluster() throws Exception {
+ configureCluster(1).configure();
+ }
+
+ @Test
+ public void testClientVersionOnly() throws Exception {
+ String[] toolArgs = new String[] {"version"};
+ CLITestHelper.TestingRuntime runtime = new
CLITestHelper.TestingRuntime(true);
+ VersionTool tool = new VersionTool(runtime);
+ tool.runTool(SolrCLI.processCommandLineArgs(tool, toolArgs));
+
+ String output = runtime.getOutput();
+ assertTrue("Output should contain 'Client version:'",
output.contains("Client version:"));
Review Comment:
In other code I saw a nicer assert style for contains in a settingš¤, though
I can't remember right now what it was!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
