janhoy commented on code in PR #4275:
URL: https://github.com/apache/solr/pull/4275#discussion_r3089324932
##########
solr/core/src/java/org/apache/solr/cli/VersionTool.java:
##########
@@ -31,8 +40,24 @@ public String getName() {
return "version";
}
+ @Override
+ public Options getOptions() {
+ return super.getOptions()
+ .addOption(CommonCLIOptions.SOLR_URL_OPTION)
+ .addOption(CommonCLIOptions.CREDENTIALS_OPTION);
+ }
+
@Override
public void runImpl(CommandLine cli) throws Exception {
- CLIO.out("Solr version is: " + SolrVersion.LATEST);
+ echo("Client version: " + SolrVersion.LATEST);
Review Comment:
Two options:
- Break compat
- Print three lines, both old and new format:
```
Solr version is: 11.0.0
Client version: 11.0.0
Server version: 11.0.0
```
That would satisfy scripts grepping for "Solr version is:" and act as a kind
of deprecation. But it also looks a bit weird to repeat it like this.
For now I'll just stick to the new output only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
