janhoy commented on code in PR #4275:
URL: https://github.com/apache/solr/pull/4275#discussion_r3068624402
##########
solr/core/src/java/org/apache/solr/cli/VersionTool.java:
##########
@@ -31,8 +40,24 @@ public String getName() {
return "version";
}
+ @Override
+ public Options getOptions() {
+ return super.getOptions()
+ .addOption(CommonCLIOptions.SOLR_URL_OPTION)
+ .addOption(CommonCLIOptions.CREDENTIALS_OPTION);
+ }
+
@Override
public void runImpl(CommandLine cli) throws Exception {
- CLIO.out("Solr version is: " + SolrVersion.LATEST);
+ echo("Client version: " + SolrVersion.LATEST);
Review Comment:
This is a back compatibility break, but I think one we can live with?
Note that also `--version` calls the version tool and gets this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
