epugh commented on PR #4280: URL: https://github.com/apache/solr/pull/4280#issuecomment-4233830289
I am somewhat ambivalent about this... I guess I am worried that by carving this into it's own test infrastructure, that we end up never running it. I worry it will become like some of the Nightly tests, that never get run by us locally and therefore when they do get run they break, which is frustrating, and or no one pays attention to the errors. Thinking out loud... 1) How could we make the test faster? It might be interesting to try and understand why it feels slow... Maybe identify some things we need to work on? 2) What about moving it to run as part of the Docker tests? That way we could test rolling upgrade against a freshly built Docker image which might be useful. 3) We are moving towards more Docker based testing infrastructure, like for Tika. Maybe we just declare that Docker is required for the `iTest`? What do you think the criteria SHOULD be for moving items into `testSmokeBats`? Maybe having clearer expectations and having more tests moving would help me wrap my head around it. Right now it just feels like we are sending this one test off to bit rot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
