dsmiley commented on code in PR #4280:
URL: https://github.com/apache/solr/pull/4280#discussion_r3073396373
##########
solr/packaging/build.gradle:
##########
@@ -311,10 +310,58 @@ task integrationTests(type: BatsTask) {
environment BATS_LIB_PREFIX: "$nodeProjectDir/node_modules"
}
+task testSmokeBats(type: BatsTask) {
Review Comment:
Yeah I don't like repetition; I suspected it but didn't look. I may try to
reduce it.
What I want to see happen (separate issue/PR) is what I said in my dev list
email -- this tech becoming a kind of gradle build infra that can be used
wherever we want -- not just specifically where it lives now. If we do that,
then I would imagine a new gradle task type for BATS for Solr that would have
such vars built-in and we wouldn't need to say much to add a new gradle target
using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
