janhoy commented on code in PR #4236:
URL: https://github.com/apache/solr/pull/4236#discussion_r3078522823
##########
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java:
##########
@@ -440,5 +443,20 @@ public void initializeMetrics(SolrMetricsContext
parentContext, Attributes attri
commExecutor =
solrMetricsContext.instrumentedExecutorService(
commExecutor, "solr.core.executor", "httpShardExecutor",
SolrInfoBean.Category.QUERY);
+ if (defaultClient != null) {
+ asyncRequestsGauge =
+ solrMetricsContext.observableLongGauge(
+ "solr.http.client.async_permits",
+ "Outstanding async HTTP request permits in the Jetty SolrJ
client"
+ + " (state=max: configured ceiling; state=available:
currently unused permits).",
Review Comment:
It was renamed to `solr.http.client.async_permits` as it felt more
descriptive. But perhaps it is self explanatory that the original
`solr.http.client.async_requests` with labels `max` and `available` is about
request permits?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
