dsmiley commented on code in PR #4236:
URL: https://github.com/apache/solr/pull/4236#discussion_r3083855591


##########
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java:
##########
@@ -440,5 +443,20 @@ public void initializeMetrics(SolrMetricsContext 
parentContext, Attributes attri
     commExecutor =
         solrMetricsContext.instrumentedExecutorService(
             commExecutor, "solr.core.executor", "httpShardExecutor", 
SolrInfoBean.Category.QUERY);
+    if (defaultClient != null) {
+      asyncRequestsGauge =
+          solrMetricsContext.observableLongGauge(
+              "solr.http.client.async_permits",

Review Comment:
   See 
https://github.com/apache/solr/blob/2c55000296bb04e12e2bfae83eca7e5f11caba0e/solr/core/src/java/org/apache/solr/util/stats/InstrumentedHttpListenerFactory.java
 but I'm a bit unclear what those names look like in practice... I see it's 
underscore based and no dots so I'm confused admittedly.  I know there have 
been some dot/underscore transformations and I forget where things stand.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to