janhoy commented on code in PR #4236:
URL: https://github.com/apache/solr/pull/4236#discussion_r3085420011
##########
solr/solrj-jetty/src/java/org/apache/solr/client/solrj/jetty/HttpJettySolrClient.java:
##########
@@ -127,6 +131,16 @@ public class HttpJettySolrClient extends
HttpSolrClientBase {
private ExecutorService executor;
private boolean shutdownExecutor;
+ /** Fallback for {@code onFailure} dispatch; unbounded so it never rejects.
*/
+ private final ExecutorService failureDispatchExecutor =
+ new ExecutorUtil.MDCAwareThreadPoolExecutor(
+ 1,
Review Comment:
Reverted back to not using a custom `failureDispatchExecutor` here, instead
using the shared `executor` instance, due to conflicts with sub class
`NoCloseHttpJettySolrClient`. So this particular code is now gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
