epugh commented on PR #4320: URL: https://github.com/apache/solr/pull/4320#issuecomment-4304177883
> > Shouldn't `solrCloud` be `connectionString`? I was hoping down the road we could put more into the connection string like username password or other details that are needed.... > > @dsmiley previously suggested naming this parameter `solrCloud` in the jira ticket comments. However, it looks like there might be some disagreement here, so it would be good to reach a consensus before finalizing the name. Agreed... I believe the intent is to specify how you connect to your running Solr? In the first PR I believe it was `connectionString` which makes sense as "hey, I'm going to have to parse this thing, and it tells me how to connect". @dsmiley ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
