dsmiley commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3138017144
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/graph/ShortestPathStream.java:
##########
@@ -79,7 +79,7 @@ public class ShortestPathStream extends TupleStream
implements Expressible {
private SolrParams queryParams;
public ShortestPathStream(
- String zkHost,
+ String solrCloud,
Review Comment:
What ought to be deprecated vs okay to change whenever is often a gray area
taking some experience with the project. Even though I haven't personally used
the code being changed in this way, I suspect that the only constructor that
matters on these things is the `StreamExpression expression, StreamFactory
factory` one. Notice that the other is only used in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]