vyatkinv commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3135574169
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/graph/ShortestPathStream.java:
##########
@@ -79,7 +79,7 @@ public class ShortestPathStream extends TupleStream
implements Expressible {
private SolrParams queryParams;
public ShortestPathStream(
- String zkHost,
+ String solrCloud,
Review Comment:
`String` can be replaced with `record` in private methods, but I'm not sure
about public constructors. Even if they are not used within the project, they
can still be used by consumers. We can declare them deprecated and introduce
new ones with Record
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
