vyatkinv commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3176895036
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java:
##########
@@ -107,7 +106,8 @@ public CloudSolrStream(StreamExpression expression,
StreamFactory factory) throw
expression));
}
- // Validate there are no unknown parameters - zkHost and alias are
namedParameter, so we don't
+ // Validate there are no unknown parameters - solrCloud/zkHost and alias
are namedParameter, so
+ // we don't
// need to count it twice
Review Comment:
I tried to restore it, but running `./gradlew tidy` reformats the file since
solrConnection is longer than zkHost.
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java:
##########
@@ -107,7 +106,8 @@ public CloudSolrStream(StreamExpression expression,
StreamFactory factory) throw
expression));
}
- // Validate there are no unknown parameters - zkHost and alias are
namedParameter, so we don't
+ // Validate there are no unknown parameters - solrCloud/zkHost and alias
are namedParameter, so
+ // we don't
// need to count it twice
Review Comment:
done
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/DeepRandomStream.java:
##########
@@ -102,7 +101,8 @@ public DeepRandomStream(StreamExpression expression,
StreamFactory factory) thro
expression));
}
- // Validate there are no unknown parameters - zkHost and alias are
namedParameter, so we don't
+ // Validate there are no unknown parameters - solrCloud and alias are
namedParameter, so we
+ // don't
// need to count it twice
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
