vyatkinv commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3176907713
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/SignificantTermsStream.java:
##########
@@ -81,17 +80,17 @@ public SignificantTermsStream(
int numTerms)
throws IOException {
- init(collectionName, zkHost, params, field, minDocFreq, maxDocFreq,
minTermLength, numTerms);
+ init(collectionName, solrCloud, params, field, minDocFreq, maxDocFreq,
minTermLength, numTerms);
}
public SignificantTermsStream(StreamExpression expression, StreamFactory
factory)
throws IOException {
// grab all parameters out
String collectionName = factory.getValueOperand(expression, 0);
List<StreamExpressionNamedParameter> namedParams =
factory.getNamedOperands(expression);
- StreamExpressionNamedParameter zkHostExpression =
factory.getNamedOperand(expression, "zkHost");
- // Validate there are no unknown parameters - zkHost and alias are
namedParameter, so we don't
+ // Validate there are no unknown parameters - solrCloud/zkHost and alias
are namedParameter, so
+ // we don't
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]