vyatkinv commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3176902643
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/FeaturesSelectionStream.java:
##########
@@ -86,18 +85,18 @@ public FeaturesSelectionStream(
int numTerms)
throws IOException {
- init(collectionName, zkHost, params, field, outcome, featureSet,
positiveLabel, numTerms);
+ init(collectionName, solrCloud, params, field, outcome, featureSet,
positiveLabel, numTerms);
}
- /** logit(collection, zkHost="", features="a,b,c,d,e,f,g", outcome="y",
maxIteration="20") */
+ /** logit(collection, solrCloud="", features="a,b,c,d,e,f,g", outcome="y",
maxIteration="20") */
public FeaturesSelectionStream(StreamExpression expression, StreamFactory
factory)
throws IOException {
// grab all parameters out
String collectionName = factory.getValueOperand(expression, 0);
List<StreamExpressionNamedParameter> namedParams =
factory.getNamedOperands(expression);
- StreamExpressionNamedParameter zkHostExpression =
factory.getNamedOperand(expression, "zkHost");
- // Validate there are no unknown parameters - zkHost and alias are
namedParameter, so we don't
+ // Validate there are no unknown parameters - solrCloud and alias are
namedParameter, so we
+ // don't
// need to count it twice
Review Comment:
done
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/FeaturesSelectionStream.java:
##########
@@ -86,18 +85,18 @@ public FeaturesSelectionStream(
int numTerms)
throws IOException {
- init(collectionName, zkHost, params, field, outcome, featureSet,
positiveLabel, numTerms);
+ init(collectionName, solrCloud, params, field, outcome, featureSet,
positiveLabel, numTerms);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
