vyatkinv commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3177788022
##########
solr/modules/sql/src/java/org/apache/solr/handler/sql/SolrTable.java:
##########
@@ -295,7 +297,7 @@ private Metric getMetric(Pair<String, String> metricPair) {
}
private TupleStream handleSelect(
- String zk,
+ CloudSolrClient.CloudSolrClientConnection solrClientConnection,
Review Comment:
done
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/CloudSolrStream.java:
##########
@@ -106,9 +110,9 @@ public CloudSolrStream(StreamExpression expression,
StreamFactory factory) throw
expression));
}
- // Validate there are no unknown parameters - solrCloud/zkHost and alias
are namedParameter, so
- // we don't
- // need to count it twice
+ // Validate there are no unknown parameters - solrConnection/zkHost and
alias are
+ // namedParameter,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
