vyatkinv commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3177789638
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/RandomStream.java:
##########
@@ -135,12 +138,14 @@ public StreamExpressionParameter
toExpression(StreamFactory factory) throws IOEx
expression.addParameter(collection);
// parameters
- for (Entry<String, String> param : props.entrySet()) {
- expression.addParameter(new
StreamExpressionNamedParameter(param.getKey(), param.getValue()));
+ for (Entry<String, String[]> param : props) {
+ for (String paramValue : param.getValue()) {
+ expression.addParameter(new
StreamExpressionNamedParameter(param.getKey(), paramValue));
+ }
}
Review Comment:
done. added method `addParameters` to `StreamExpression`
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/SignificantTermsStream.java:
##########
@@ -395,26 +406,24 @@ public SignificantTermsCall(
@Override
public NamedList<?> call() throws Exception {
- ModifiableSolrParams params = new ModifiableSolrParams();
+ ModifiableSolrParams queryRequestParams = new ModifiableSolrParams();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
