vyatkinv commented on PR #4320: URL: https://github.com/apache/solr/pull/4320#issuecomment-4365709297
I’ve addressed several minor review comments and updated the streaming documentation. In addition, I added validation to ensure that the legacy zkHost parameter is strictly a ZooKeeper connection string. Next steps (planned shortly): Add tests for the solrConnection parameter Extend support for solrConnection in the SQL module and StreamingTool CLI Document these changes in major-changes-in-solr-10.adoc, noting that these modules will support both ZooKeeper- and HTTP(S)-based connections One open question is the SQL module. Supporting HTTP(S) connections there may be less straightforward, since a connection string like: jdbc:solr://http://solr1:8080/solr,http://solr2:8080/solr?collection=foo looks somewhat awkward and potentially problematic. I’d appreciate any suggestions on the best way to approach this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
