dsmiley commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3179444595
##########
solr/solr-ref-guide/modules/query-guide/pages/join-query-parser.adoc:
##########
@@ -306,6 +317,7 @@ The name of the external Solr collection to be queried to
retrieve the set of jo
The connection string to be used to connect to ZooKeeper.
`zkHost` and `solrUrl` are both optional parameters, and at most one of them
should be specified.
If neither `zkHost` nor `solrUrl` are specified, the local ZooKeeper cluster
will be used.
+This parameter are deprecated. Use `solrConnection` instead.
Review Comment:
"is" not "are"
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/ModelCache.java:
##########
@@ -31,20 +32,24 @@
public class ModelCache {
private LRU models;
- private String defaultZkHost;
+ private CloudSolrClient.CloudSolrClientConnection solrConnection;
private SolrClientCache solrClientCache;
public ModelCache(int size, String defaultZkHost, SolrClientCache
solrClientCache) {
this.models = new LRU(size);
- this.defaultZkHost = defaultZkHost;
+ this.solrConnection =
CloudSolrClient.CloudSolrClientConnection.parse(defaultZkHost);
Review Comment:
this should flow through to the constructor. (no need for back-compat here
IMO)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
