dsmiley commented on code in PR #4023:
URL: https://github.com/apache/solr/pull/4023#discussion_r3201816360
##########
solr/test-framework/src/java/org/apache/solr/SolrIgnoredThreadsFilter.java:
##########
@@ -88,6 +88,12 @@ public boolean reject(Thread t) {
return true;
}
+ // Static backup/restore thread pools - stateless, no core references,
threads expire on idle
+ if (threadName.startsWith("IncrementalBackupExecutor-")
Review Comment:
I wish this was a bit easier and/or regularized within the codebase, but
somehow this Executor needs to be associated with CoreContainer. What many
Solr hackers don't know is that the CoreContainer.getObjectCache can be used
as its entries are closed on shutdown if they implement Closeable. So what you
can do is inside these classes you are modifying that have access to SolrCore,
call getCoreContainer().getObjectCache() and then put a custom Closeable whose
close method calls ExecutorUtil.shutdownAndAwaitTermination on the executor.
so the executor will be on a field in an object in the ObjectCache on the
CoreContainer. I hope that makes sense. Yes it's a bit clumsy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
