dsmiley commented on code in PR #4023:
URL: https://github.com/apache/solr/pull/4023#discussion_r3201905741
##########
solr/test-framework/src/java/org/apache/solr/SolrIgnoredThreadsFilter.java:
##########
@@ -88,6 +88,12 @@ public boolean reject(Thread t) {
return true;
}
+ // Static backup/restore thread pools - stateless, no core references,
threads expire on idle
+ if (threadName.startsWith("IncrementalBackupExecutor-")
Review Comment:
I think it'd be reasonable to enhance
https://github.com/apache/solr/blob/1209027537bf929e5a0149eda92d76571ce936ac/solr/solrj/src/java/org/apache/solr/common/util/ObjectCache.java#L87
to check if the value implements `Executor` and if so then call
`shutdownAndAwaitTermination`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
