dsmiley commented on code in PR #4023:
URL: https://github.com/apache/solr/pull/4023#discussion_r3201857101
##########
solr/test-framework/src/java/org/apache/solr/SolrIgnoredThreadsFilter.java:
##########
@@ -88,6 +88,12 @@ public boolean reject(Thread t) {
return true;
}
+ // Static backup/restore thread pools - stateless, no core references,
threads expire on idle
+ if (threadName.startsWith("IncrementalBackupExecutor-")
Review Comment:
Looking at IncrementalShardBackup.java and [how it's
used](https://github.com/apache/solr/blob/470ae762b883b259da6f127844855395e9eedf9f/solr/core/src/java/org/apache/solr/handler/admin/api/CreateCoreBackup.java#L99),
I suppose it's a bit cleaner for the caller to concern itself with providing
the ExecutorService to IncrementalShardBackup. Dependency-injection.
Similar to restoring a core
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
