mlbiscoc commented on PR #4404: URL: https://github.com/apache/solr/pull/4404#issuecomment-4423404434
> @mlbiscoc I think we may be able to elminate JettySolrRunnerWithMetrics as well... I poked around and it appears that it is no longer used in testing, it exists for two classes, but isn't actively used in the asserts, it just sits there... > > I played around a bit and got this patch file: [remove_jettymetricstestframework.patch](https://github.com/user-attachments/files/27521296/remove_jettymetricstestframework.patch). This could also be in another PR... Maybe this is a breaking chnage to our test-framework? I think though, it's minimal if it is, and in a perfect world would have been part of our Solr 10 Test Framework changes anyway. I took a look and applied it to this PR. I think it's worth adding. The jetty metrics were essentially a no-op in 10 at this point anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
