dsmiley commented on code in PR #4404:
URL: https://github.com/apache/solr/pull/4404#discussion_r3221411251
##########
changelog/unreleased/SOLR-17855-dropwizard-removal.yml:
##########
@@ -0,0 +1,9 @@
+title: Remove Dropwizard Metrics as a direct Solr dependency. The
`OVERSEERSTATUS` response no longer includes per-operation timing metrics or
queue stats; success/error counts are preserved.
Review Comment:
We can also advise that tracing is a substitute for per-operation metrics.
##########
solr/benchmark/src/java/org/apache/solr/bench/SolrBenchState.java:
##########
@@ -598,4 +589,10 @@ public static Path getFile(String name) {
+ " CWD="
+ Path.of("").toAbsolutePath());
}
+
+ private static void logIndexingRate(long docCount, long startNanos) {
+ long elapsedMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() -
startNanos);
Review Comment:
as we're logging at docs per SECOND, why convert to milliseconds at an
intermediate step? It's okay if we round to a whole number... docs/sec should
be rather high anyway. It's also okay if you want to add a fraction.
##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc:
##########
@@ -323,6 +323,10 @@ Users who consume Solr metrics via OTLP and rely on the
10.0 underscore-format n
The metric `solr_core_indexsearcher_open_warmup_time` has been removed as it
duplicated `solr_core_indexsearcher_warmup_time`.
Update your dashboards to use `solr_core_indexsearcher_warmup_time` instead.
+==== Overseer Status Metrics Removed
+
+The `OVERSEERSTATUS` Collection API response no longer includes per-operation
timing metrics but per-operation `requests` and `errors` counts still exist.
Review Comment:
mention that OTEL tracing can be used to get similar information indirectly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
