epugh commented on code in PR #2391:
URL: https://github.com/apache/solr/pull/2391#discussion_r3241365135
##########
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##########
@@ -192,13 +196,62 @@ public void initZooKeeper(final CoreContainer cc,
CloudConfig config) {
e);
}
} else if (zkServerEnabled) {
- // Old school ZooKeeperServerMain being used under the covers (bin/solr
-c without ZK_HOST).
- zkServer =
- SolrZkServer.createAndStart(config.getZkHost(), solrHome,
config.getSolrHostPort());
+ try {
+ final Path zkDataHome =
+ Path.of(
+ EnvUtils.getProperty(
+ "solr.zookeeper.server.datadir",
solrHome.resolve("zoo_data").toString()));
Review Comment:
There is NOT a strong pattern. I think it's personal preference. For
me, I always find the text version easier to read than the
`SOLR_ZOOKEEPER_SERVER_DETAILED` version ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
