renatoh commented on code in PR #4475:
URL: https://github.com/apache/solr/pull/4475#discussion_r3329226127
##########
solr/core/src/java/org/apache/solr/search/join/FiltersQParser.java:
##########
@@ -59,7 +59,14 @@ protected BooleanQuery parseImpl() throws SyntaxError {
BooleanQuery.Builder builder = createBuilder();
for (Map.Entry<QParser, Occur> clause : clauses.entrySet()) {
- builder.add(unwrapQuery(clause.getKey().getQuery(), clause.getValue()),
clause.getValue());
+
+ Query query = clause.getKey().getQuery();
+ Occur occur = clause.getValue();
+
+ if (occur == Occur.SHOULD && query instanceof BooleanQuery boolQ &&
boolQ.clauses().isEmpty()) {
Review Comment:
I can only work with what the LuceneQParser returns, and in this case it is
a BooleanQuery with an empty List of clauses. And as I understand it, I can
only safely drop a Query with an empty list of clauses if it is a SHOULD. I do
not see any attribute on BooleanQuery I could check for null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
