renatoh commented on PR #4475: URL: https://github.com/apache/solr/pull/4475#issuecomment-4629869910
@dsmiley I had a look at some failing tests, bellow my analysis. Would be great to get your inputs on my findings. Thanks! org.apache.solr.util.SolrPluginUtilsTest#testDisjunctionMaxQueryParser Fails since it expects name:the to be dropped entirely from the query, now we get a MatchNoDocsQuery, the number of expected queries does not match anymore. Null query get skipped here: org/apache/solr/util/SolrPluginUtils.java:896 This test was a pain to analyze and to debug since it tests so many different things and the last assert failed, I broke that test up into several smaller test cases, the failing now is: testDismaxParser_stopWordReducesDMQClauseCount org.apache.solr.search.TestExtendedDismaxParser#testFocusQueryParser That’s an interesting one, apparently edismax has a flag alwaysStopwords, which was introduced here: https://issues.apache.org/jira/projects/SOLR/issues/SOLR-17959 So it expects the stop words only to be dropped from the query if alwaysStopwords=true, but now they are dropped regardless of the flag. org.apache.solr.search.TestExtendedDismaxParser#testSplitOnWhitespace_shouldRespectMinimumShouldMatch. The test expect the query below to not return any documents, since only one out of the conditions are matching: mm=100%&q=Terminator: 100&defType=edismax&df=text&qf=movies_t foo_i Searching for a text in an integer field foo_i creates a MatchNoDocsQuery, with my changes to org.apache.solr.util.SolrPluginUtils#setMinShouldMatch are ignored when calculating the absolute mm, hence 100% means for this query now 1 out of 1, and not 2 out of 2 as it did before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
